Enable approx_percentile by default #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
sameerz
added
the
task
|
build |
revans2
previously approved these changes
Jan 11, 2022
| @@ -3249,6 +3249,11 @@ object GpuOverrides extends Logging { | |||
| (c, conf, p, r) => new TypedImperativeAggExprMeta[ApproximatePercentile](c, conf, p, r) { | |||
|
|
|||
| override def tagAggForGpu(): Unit = { | |||
There was a problem hiding this comment.
If you look at Upper or Lower as an example there is a built in way to mark an entire operator as incompat and it lets us put in a doc string with it to explain how it is incompat.
}).incompat("The GPU implementation of approx_percentile is not bit-for-bit " +
"compatible with Apache Spark.")
There was a problem hiding this comment.
Ah, I didn't realize we had that. That looks much better and I will update this.
jlowe
reviewed
Jan 11, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
approved these changes
Jan 11, 2022
revans2
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Enable approx_percentile by default.