Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test for LIKE with embedded null character #4682

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Enable test for LIKE with embedded null character #4682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182cf66
enable test for LIKE with embedded null character
andygrove Feb 2, 2022
bfabc8a
update docs
andygrove Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docs/compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,12 +482,6 @@ The nested types(array, map and struct) are not supported yet in current version

Like the CSV reader, the JSON reader has the same floating point issue. Please refer to [CSV Floating Point](#csv-floating-point) section.

## LIKE

If a null char '\0' is in a string that is being matched by a regular expression, `LIKE` sees it as
the end of the string. This will be fixed in a future release. The issue is
[here](https://github.com/NVIDIA/spark-rapids/issues/119).

## Regular Expressions

The following Apache Spark regular expression functions and expressions are supported on the GPU:
Expand Down
3 changes: 1 addition & 2 deletions integration_tests/src/main/python/string_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,7 @@ def test_initcap_special_chars():
lambda spark: unary_op_df(spark, gen).select(
f.initcap(f.col('a'))))

@pytest.mark.xfail(reason='https://github.com/NVIDIA/spark-rapids/issues/119')
def test_like_null_xfail():
def test_like_null():
gen = mk_str_gen('.{0,3}a[|b*.$\r\n]{0,2}c.{0,3}')\
.with_special_pattern('.{0,3}oo.{0,3}', weight=100.0)\
.with_special_case('_')\
Expand Down