Re-enables partial regex support for octal digits on the GPU #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Kumar <navink@nvidia.com>
…nspiler Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
Just a small question. If we can parse them properly why not switch them over to something that CUDF does support? like hex digits? |
revans2
reviewed
Feb 9, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
CUDF actually also doesn't support hex digits in the range that corresponds to 128-255 |
Signed-off-by: Navin Kumar <navink@nvidia.com>
revans2
approved these changes
Feb 9, 2022
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
andygrove
approved these changes
Feb 9, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4409.
Since a couple of underlying
libcudfissues with octal digit support in regular expression have now been resolved, this code re-enables octal digit support with the appropriate transpiling from Java Pattern support to libcudf regular expression format. A couple of known limitations:\200to\377are not supported bylibcudf, so this will still fallback to CPU[\022]) inlibcudf, so this will also fallback to CPUDocumentation has been updated to reflect these limitations.