Add avro reader support [databricks] #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
use data gen instead of testing file Signed-off-by: remzi <13716567376yh@gmail.com>
Add basic avro reading test
wbo4958
changed the title
wbo4958
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
|
build |
|
build |
This was referenced Mar 18, 2022
|
build |
1 similar comment
|
build |
|
build |
jlowe
previously approved these changes
Mar 21, 2022
revans2
previously approved these changes
Mar 21, 2022
firestarman
reviewed
Mar 22, 2022
| # Only 3 jars: cudf.jar dist.jar integration-test.jar | ||
| ALL_JARS="$CUDF_JARS $PLUGIN_JARS $TEST_JARS" | ||
| ALL_JARS="$CUDF_JARS $PLUGIN_JARS $TEST_JARS $AVRO_JARS" |
There was a problem hiding this comment.
NIT: Better to check whether the avro jar exists. If not, set AVRO_JARS="" and CI_EXCLUDE_AVRO=true as well.
firestarman
reviewed
Mar 22, 2022
| # | ||
| # `CI_EXCLUDE_AVRO=true ./run_pyspark_from_build.sh -k not avro_test.py` run all tests excluding | ||
| # those in avro_test.py | ||
| if [[ "${CI_EXCLUDE_AVRO}" != "" ]]; |
There was a problem hiding this comment.
Suggested change
| if [[ "${CI_EXCLUDE_AVRO}" != "" ]]; | |
| if [[ "${CI_EXCLUDE_AVRO}" == "true" ]]; |
otherwise, CI_EXCLUDE_AVRO=false can also skip the tests.
|
build |
|
build |
1 similar comment
|
build |
revans2
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to support the avro reader on basic type support.
Since there is no meta info for the block data, this PR first iterates the whole avro file to get all the block info, it didn't read all files. instead, it only needs to read small bytes by seeking the desired position, then filters the blocks according to the PartitionedFile. finally read the blocks into CPU and send to GPU to decode ...
Close #4935 .
Re #4831 .