Add support for ORC forced positional evolution #4972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
Adding a test is always a good idea, even if it's a simple one just to do a sanity check |
|
This looks good, but agree it would be nice to have a test to show this works. The original Spark PR could be a reference of how to approach testing this. |
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
nartal1
changed the title
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
jlowe
approved these changes
Mar 25, 2022
razajafri
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1922
This is to keep OrcUtils in sync with Spark's code. In the Spark PR apache/spark#29737 they have added a check for 'orc.force.positional.evolution` for matching top level column by position.
Updated the code so that when this config is set, we read the columns based on positions and not the column names.
Added test to verify the behavior.