Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip failing tests for Spark 3.3.0 #5313

Merged
merged 2 commits into from
Apr 26, 2022
Merged

skip failing tests for Spark 3.3.0 #5313

merged 2 commits into from
Apr 26, 2022

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Apr 26, 2022 •
edited
Loading

There was a bug introduced in Spark 3.3.0. Skipping tests until https://issues.apache.org/jira/browse/SPARK-39015 is fixed

fixes #5260

Signed-off-by: Raza Jafri rjafri@nvidia.com

@razajafri
skipping tests until
86f2c82 
https://issues.apache.org/jira/browse/SPARK-39015 is fixed

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
tgravescs previously approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, although they already have a fix up for the spark issue so we may just wait to see if that goes in today.

@tgravescs
Copy link
Collaborator

build

@razajafri
Copy link
Collaborator Author

Thank @tgravescs. I am watching that issue

@razajafri
switch skipif to xfail
7595bd0 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri
Copy link
Collaborator Author

build

@jlowe
Copy link
Member

jlowe commented Apr 26, 2022

Are we going to have a followup to track re-enabling the test? It looks like the fix for SPARK-39015 is imminent.

@razajafri
Copy link
Collaborator Author

Are we going to have a followup to track re-enabling the test? It looks like the fix for SPARK-39015 is imminent.

I have created a follow-on #5318

@razajafri razajafri merged commit fa7840b into NVIDIA:branch-22.06 Apr 26, 2022
@razajafri razajafri deleted the SP-5260-map_test_fix branch April 26, 2022 16:04
@sameerz sameerz added test Only impacts tests spark 3.3+ labels Apr 26, 2022
@sameerz sameerz added this to the Apr 18 - Apr 29 milestone Apr 26, 2022
razajafri added a commit to razajafri/spark-rapids that referenced this pull request Apr 28, 2022
@razajafri
Revert "skip failing tests for Spark 3.3.0 (NVIDIA#5313)"
764868a 
This reverts commit fa7840b.

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
tgravescs pushed a commit that referenced this pull request Apr 29, 2022
@razajafri
Revert "skip failing tests for Spark 3.3.0 (#5313)" (#5360)
70155f5 
This reverts commit fa7840b.

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@tgravescs tgravescs tgravescs left review comments

Assignees

@razajafri razajafri

Labels
spark 3.3+ test Only impacts tests
Projects
None yet
Milestone
Apr 18 - Apr 29
Development

Successfully merging this pull request may close these issues.

[BUG] map_test failures on Spark 3.3.0
4 participants
@razajafri @tgravescs @jlowe @sameerz