Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Clean up the tests of concat_list #5560

Merged
merged 2 commits into from
May 20, 2022

Conversation

HaoYang670
Copy link
Collaborator

@HaoYang670 HaoYang670 commented May 20, 2022

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None.

What changes are included in this PR?

Just to merge some separate tests to save some runtime.

Run bash run_pyspark_from_build.sh -k concat_list

Before:

=============== 57 passed, 14156 deselected in 125.44s (0:02:05) ===============

After:

(one less test becase test_concat_list_empty is merged in test_concat_list.)

==================== 56 passed, 14156 deselected in 59.20s =====================

We can save about 1 minute on testing!

Are there any user-facing changes?

No.

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@HaoYang670 HaoYang670 mentioned this pull request May 20, 2022
@HaoYang670 HaoYang670 self-assigned this May 20, 2022
@HaoYang670
Copy link
Collaborator Author

build

@sameerz sameerz added the test Only impacts tests label May 20, 2022
@sameerz sameerz added this to the May 2 - May 20 milestone May 20, 2022
@revans2 revans2 merged commit dad504f into NVIDIA:branch-22.06 May 20, 2022
@HaoYang670 HaoYang670 deleted the merge_tests branch May 20, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants