Update Spark2 explain code for 22.06 #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
|
build |
|
Build failure is due to #5744 |
|
build |
nartal1
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
LGTM. I ran diff for some of the files locally and got the same results as above.
@tgravescs Can this be merged now OR should we wait for pending PR's for 22.06 ?
|
as far as I know everything pending isn't messing with the metadata but I'll keep an eye out. merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5451.
Update the spark 2.x explain api code to pull in all the various changes. Run through the diff script and udpated everything I saw. I manually ran this against tpcds queries and looked at output, only diff from 22.04 was dealing with a cast (Casting from floating point types to integral types) is now supported because we enabled it by default in 22.06.