Update spark330shim to use released lib #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53cfa49.
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
added
documentation
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
1 similar comment
|
build |
gerashegalov
requested changes
Jun 16, 2022
| @@ -171,6 +171,7 @@ case $DIST_PROFILE in | |||
| 313 | |||
| 320 | |||
| 321 | |||
| 330 | |||
There was a problem hiding this comment.
We should drop it from snapshots?(WithDatabricks)) on L162
|
build |
gerashegalov
approved these changes
Jun 16, 2022
NvTimLiu
approved these changes
Jun 16, 2022
jlowe
reviewed
Jun 16, 2022
| // temporarily allow 3.3.1 while 3.3.0 release candidates are being produced | ||
| private val VERSION331 = SparkShimVersion(3, 3, 1) | ||
| val VERSIONNAMES = Seq(VERSION, VERSION331).flatMap(v => Seq(s"$v", s"$v-SNAPSHOT")) | ||
| val VERSIONNAMES = Seq(s"$VERSION", s"$VERSION-SNAPSHOT") |
There was a problem hiding this comment.
Snapshot support should have been removed here, posted a fix at #5858. I don't think it's must-fix for 22.06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5698
revert #5693
and update spark330 shim as non-snapshot profile