Re-enable empty repetition near end-of-line anchor for rlike, regexp_extract and regexp_replace #8081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navin Kumar <navink@nvidia.com>
…l-anchor-repetition-edge-case
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
Signed-off-by: Navin Kumar <navink@nvidia.com>
|
build |
andygrove
reviewed
Apr 12, 2023
|
build |
andygrove
approved these changes
Apr 13, 2023
abellina
pushed a commit
to abellina/spark-rapids
that referenced
this pull request
Apr 14, 2023
…extract and regexp_replace (NVIDIA#8081) * WIP: fix false positive repetition near line anchor bug Signed-off-by: Navin Kumar <navink@nvidia.com> * Enable repetition near end of line anchor edge case Signed-off-by: Navin Kumar <navink@nvidia.com> * Add regexp_replace test with empty repetition Signed-off-by: Navin Kumar <navink@nvidia.com> * Need to add unicode enabled check for these 2 unit tests Signed-off-by: Navin Kumar <navink@nvidia.com> --------- Signed-off-by: Navin Kumar <navink@nvidia.com>
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5659.
This enables regular expressions with empty repetitions adjacent to end-of-line anchors in every regular expression SQL function but
split(), a use case that had been working before but had been excluded due to other edge cases that were not functioning. This does this by modifying to checks to narrowly allow this particular case.