Rename __local variables to avoid conflict with macro defined by HIP
#1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stdexec headers are included in a build with hipcc compilation fails because of a
__localmacro defined by HIP: https://github.com/ROCm/clr/blob/1e4c60f286cb056b4117c72358302a888e65a324/hipamd/include/hip/amd_detail/device_library_decls.h#L123. It's a rather unfortunate macro name, but it's been reported to AMD (ROCm/hipamd#68; though this particular repo is archived, and the replacement repo does not have the same issue reported) and the macro is still defined on the latest development branch ofclr. I'm proposing to avoid the__localname in stdexec. I've changed existing uses to slightly more verbose names.