Add merge for sequence senders
#1659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `__debug_sequence_sender` - add `__well_formed_sequence_sender` - add static-member-fn support to `get_item_types` - add static-member-fn support to `subscribe` - add support for `STDEXEC_ENABLE_EXTRA_TYPE_CHECKING`
…nd `get_item_types`
- add `__well_formed_sequence_sender` constraint - add `__mexception` overloads for `get_item_types` - remove constraints that were causing SFINAE that would skip the debug info
each input sequence may be on a different scheduler. The merged items will invoke `set_next` on the receiver from all of the contexts. Depending on the schedulers in play, the calls to `set_next` may overlap in parallel.
ericniebler
approved these changes
Oct 1, 2025
Comment on lines
+661
to
+663
| " auto get_item_types(_Env&&...) -> exec::item_types<\n" \ | ||
| " // This sequence produces void items...\n" \ | ||
| " stdexec::__call_result_t<stdexec::just_t>,\n" \ |
There was a problem hiding this comment.
this return type is missing a trailing >
|
/ok to test 4cca273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergetakes multiple sequence-senders and forwards all the item-senders from each of the input sequences to the sameReceiver::set_nextThe calls to
Receiver::set_nextare not synchronized. If each sequence-sender is emitting on a different scheduler in parallel, then the calls toReceiver::set_nextwill also be in parallel.mergecompletes after all the sequence-senders complete.The other commits were needed to debug the
mergeimplementation.