This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
defines thrust::tuple_element consistently with std::tuple_element #1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose changing the template arguments of
thrust::tuple_element
to matchstd::tuple_element
:This is consistent with the implementation used by
<cuda/std/tuple>
While I understand that
thrust::tuple_element
will likely be replaced alongsidethrust::tuple
pending resolution of NVIDIA/cccl#742, the motivation for this PR is that the overload ofthrust::tuple_element
forthrust::pair
will also need to be replaced, since it still usestemplate<int, typename>
. This PR enables branches such as my variadic tuple branch to BJHVT (bring-jared-hoberock's-variadic-tuple) while we await mainline variadicthrust::tuple
support.With
-DTHRUST_DEVICE_SYSTEM=CPP
: