This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
thrust::iterator_traits to inherit from std::iterator_traits #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allisonvacanti as discussed offline, here's the PR! |
alliepiper
added
type: enhancement
|
Thanks! LGTM, I'll start tests and merge this soon if all goes well. DVS CL: 30202015 run tests |
alliepiper
added
testing: internal ci in progress
|
@allisonvacanti could I get help for understanding why the tests fail only for |
|
Sorry, I should have mentioned -- the icc build is broken, this PR should be good to go. I'll merge it today or tomorrow. |
alliepiper
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.