Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add make_tagged_iterator #1586

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Add make_tagged_iterator #1586

merged 2 commits into from
Apr 25, 2022

Conversation

karthikeyann
Copy link
Contributor

make_tagged_iterator<Tag, Iterator>(iterator);
tparam Iterator could be skipped due to function template type deduction.

Example usage:

  auto d_iter =
    thrust::detail::make_tagged_iterator<thrust::device_system_tag>(
      thrust::make_transform_iterator(
        thrust::make_counting_iterator(0), 
          [] __device__(int i) -> int { return i % 3; }));

make_tagged_iterator<Tag, Iterator>(iterator);
tparam `Iterator` could be skipped due to function template type deduction.
@alliepiper alliepiper added type: enhancement New feature or request. helps: rapids Helps or needed by RAPIDS. P2: nice to have Desired, but not necessary. labels Jan 10, 2022
@alliepiper alliepiper added this to the 1.16.0 milestone Jan 10, 2022
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, starting testing 👍

@alliepiper
Copy link
Collaborator

DVS CL: 30868233

run tests

@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Jan 12, 2022
@alliepiper
Copy link
Collaborator

@karthikeyann This will need to be updated with a trailing return type to support C++11:

/dvs/p4/build/sw/gpgpu/thrust/thrust/iterator/detail/tagged_iterator.h(71): error #2730-D: deduced return types are a C++14 feature

@alliepiper alliepiper removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Jan 19, 2022
@alliepiper alliepiper self-requested a review February 7, 2022 18:32
thrust/iterator/detail/tagged_iterator.h Outdated Show resolved Hide resolved
@alliepiper alliepiper modified the milestones: 1.16.0, 1.17.0 Feb 7, 2022
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
@ericniebler
Copy link
Collaborator

run tests

@ericniebler ericniebler dismissed alliepiper’s stale review April 7, 2022 17:32

Added trailing return type per change request

@alliepiper alliepiper merged commit fac3156 into NVIDIA:main Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
helps: rapids Helps or needed by RAPIDS. P2: nice to have Desired, but not necessary. type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants