This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make_tagged_iterator<Tag, Iterator>(iterator); tparam `Iterator` could be skipped due to function template type deduction.
alliepiper
added
type: enhancement
New feature or request.
helps: rapids
Helps or needed by RAPIDS.
P2: nice to have
Desired, but not necessary.
labels
Jan 10, 2022
alliepiper
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, starting testing 👍
DVS CL: 30868233 run tests |
alliepiper
added
testing: gpuCI in progress
Started gpuCI testing.
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
labels
Jan 12, 2022
jrhemstad
reviewed
Jan 13, 2022
@karthikeyann This will need to be updated with a trailing return type to support C++11:
|
alliepiper
removed
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
testing: gpuCI in progress
Started gpuCI testing.
labels
Jan 19, 2022
alliepiper
previously requested changes
Feb 7, 2022
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
run tests |
ericniebler
dismissed
alliepiper’s stale review
April 7, 2022 17:32
Added trailing return type per change request
alliepiper
approved these changes
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
helps: rapids
Helps or needed by RAPIDS.
P2: nice to have
Desired, but not necessary.
type: enhancement
New feature or request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_tagged_iterator<Tag, Iterator>(iterator);
tparam
Iterator
could be skipped due to function template type deduction.Example usage: