This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 756
Add an example that shows how to use custom CUDA streams. #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run tests |
gevtushenko
approved these changes
May 4, 2022
jrhemstad
reviewed
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It felt like after #1568 we should have a description of the synchronization behavior and describe the no_sync
version as well.
I changed the example to an inclusive_scan
instead of a reduce
since reduce
will always synchronize and inclusive_scan
demonstrates why it's important to have an execution policy that synchronizes sometimes.
Sounds good to me, added @jrhemstad's proposed changes. run tests |
jrhemstad
approved these changes
May 5, 2022
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Fixed typo. run tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P2: nice to have
Desired, but not necessary.
testing: gpuCI in progress
Started gpuCI testing.
type: enhancement
New feature or request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1626.