Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Remove cub symlink. #1701

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

alliepiper
Copy link
Collaborator

This breaks builds on some toolchains.

Users should explicitly set their include directories for Thrust's dependencies:

-I ${THRUST_ROOT}/dependencies/cub
-I ${THRUST_ROOT}/dependencies/libcudacxx/include

If using Thrust's CMake packages, these paths will be configured automatically.

Fixes #1328.

This breaks builds on some toolchains.

Users should explicitly set their include directories for Thrust's
dependencies:

```
-I ${THRUST_ROOT}/dependencies/cub
-I ${THRUST_ROOT}/dependencies/libcudacxx/include
```

If using Thrust's CMake packages, these paths will be configured
automatically.

Fixes NVIDIA#1328.
@alliepiper alliepiper added type: bug: functional Does not work as intended. P0: must have Absolutely necessary. Critical issue, major blocker, etc. release: breaking change Include in "Breaking Changes" section of release notes. type: cleanup Modernization, dead code removal, style fixes, etc. labels May 20, 2022
@alliepiper alliepiper added this to the 2.0.0 milestone May 20, 2022
@alliepiper
Copy link
Collaborator Author

run tests

@alliepiper alliepiper merged commit be34b50 into NVIDIA:main Jun 6, 2022
@alliepiper alliepiper deleted the remove_cub_symlink/gh.1328 branch June 6, 2022 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0: must have Absolutely necessary. Critical issue, major blocker, etc. release: breaking change Include in "Breaking Changes" section of release notes. testing: gpuCI in progress Started gpuCI testing. type: bug: functional Does not work as intended. type: cleanup Modernization, dead code removal, style fixes, etc.
Projects
None yet
2 participants