-
Notifications
You must be signed in to change notification settings - Fork 758
Emit diagnostics for device lambdas #1760
Emit diagnostics for device lambdas #1760
Conversation
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use CUB headers outside of thrust/system/cuda/
, as CUB is only a dependency when the CUDA backend is enabled.
Let's replicate the logic from CUB in Thrust's type_traits.h and use that instead.
All the logic is in |
Invoke result is C++17 feature. CUB wrapper switches to result of for previous dialects. |
Can't we back port It's just a library feature, and we already have back ported many Standard Library features in libcu++, e.g., NVIDIA/libcudacxx#66 |
We'd need a libcu++ release by 8/15 to do this. |
a607152
to
a78f219
Compare
run tests |
No description provided.