improve naming to represent intent; use std::generate
#753
Conversation
brycelelbach
left a comment
brycelelbach
left a comment
There was a problem hiding this comment.
Looks good to me. Should be easy to integrate to Thrust 1.9.x.
| } | ||
| std::generate(points.begin(), points.end(), [&] { | ||
| auto x = u01(rng); | ||
| auto y = u01(rng); |
There was a problem hiding this comment.
Let's avoid auto here, we're not requiring C++11 yet.
There was a problem hiding this comment.
If we're not requiring C++11, we can't use this lambda either, can we?
|
This was closed when we pushed the new Git master history to GitHub. Please rebase onto the new master and we'll take a look. |
|
That was easy. Rebased/pushed. |
|
Is something happening to this pull request? Should I close it? |
|
Hey, we will take a look at it, but we are a little backed up with our release cycle right now
Sent from Nine<http://www.9folders.com/>
…________________________________
From: xtofl <notifications@github.com>
Sent: Tuesday, December 17, 2019 4:39 AM
To: thrust/thrust
Cc: Bryce Lelbach; State change
Subject: Re: [thrust/thrust] improve naming to represent intent; use `std::generate` (#753)
Is something happening to this pull request? Should I close it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#753>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADBG4UFCNHUMDUNBZWND4DQZDB7ZANCNFSM4B5KTWAQ>.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
|
|
No problem. It is, after all, only a tiny first step in pouring 'modern C++' over the thrust examples. I think it's part of a bigger effort to take on the whole example code. To me, it's important that examples breath good style, so that when I point people at them, they fullful a larger educational purpose than just showcasing the library. I'll make an Issue (#1041) out of that, as to formalize it. |
2 participants
No description provided.