Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in the log_p() function #42

Open
univanxx opened this issue Oct 28, 2022 · 0 comments
Open

Possible typo in the log_p() function #42

univanxx opened this issue Oct 28, 2022 · 0 comments

Comments

@univanxx
Copy link

univanxx commented Oct 28, 2022

Hi there and thanks for an amazing work! I was exploring the code and in the module distributions.py found out that the logarithm of standard normal distribution (normalized_samples in the code) is:

$$ \ln(p) = -0.5 \cdot x^2 - 0.5 \cdot \ln(2 \cdot \pi) - \ln(\sigma). $$

But why do we need a $\ln(\sigma)$ part? Isn't the formula above should look like:

$$ \ln(p) = -0.5 \cdot x^2 - 0.5 \cdot \ln(2 \cdot \pi)? $$

Thanks in advance for the clarifications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant