Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples_tx_indices problem #621

Open
StevenHe1006 opened this issue Oct 16, 2024 · 2 comments
Open

samples_tx_indices problem #621

StevenHe1006 opened this issue Oct 16, 2024 · 2 comments

Comments

@StevenHe1006
Copy link

In the SolverCoverageMap._shoot_and_bounce function, samples_tx_indices stores the indices of the transmitters corresponding to all ray samples. However, when calculating reflection and diffuse reflection, operations like updated_e_field = tf.concat([updated_e_field, ref_e_field], axis=0) actually change the order in which the rays are stored. Should samples_tx_indices be adjusted accordingly?

@StevenHe1006
Copy link
Author

Same question for the tensor k_tx

@faycalaa
Copy link
Collaborator

Hi @StevenHe1006,

Thank you for reporting this issue. We've confirmed that this is indeed a bug. It will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants