hostlib: support build-time override of the EN_PIN #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also the imx version could easily be merged, and there should be an option to not use an EN pin at all in case it is tied to VCC. |
|
Anyone from @NXP is here? I now see the same issue for all |
the EN_PIN is currently hard coded into se05x_reset.c the EN_PIN is board specific and should be modified per configuration. It should actually be runtime parameter, similar to the i2c device and i2c device address. Let's at least support build time configuration to avoid patching. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
alonbl
force-pushed
the
reset
branch
2 times, most recently
from
1d7c96e
to
1b484ba
Compare
|
It is even worse the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the EN_PIN is currently hard coded into se05x_reset.c the EN_PIN is board specific and should be modified per configuration.
It should actually be runtime parameter, similar to the i2c device and i2c device address.
Let's at least support build time configuration to avoid patching.