Add modal component, story, and theme #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meek-klepon-586e39 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TangoYankee
reviewed
Aug 29, 2024
TangoYankee
requested changes
Aug 29, 2024
There was a problem hiding this comment.
I think the onClose argument in the Modal story makes things more convoluted than they need to be. I opened a PR against this one to show what I mean. Let me know what you think.
pratishta
force-pushed
the
59-add-modal-component
branch
from
e56136c
to
25a0702
Compare
|
@TangoYankee Good catch. I updated the Drawer component to also have its |
TangoYankee
requested changes
Aug 30, 2024
pratishta
force-pushed
the
59-add-modal-component
branch
from
25a0702
to
852db6e
Compare
TangoYankee
reviewed
Aug 30, 2024
Update onClose in Modal and Drawer Change name to toggleOpen Include ModalBodyProps and export remaining sub components Add close button props
pratishta
force-pushed
the
59-add-modal-component
branch
from
852db6e
to
d959d4b
Compare
TangoYankee
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59