Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ember QUnit #601

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Upgrade Ember QUnit #601

merged 1 commit into from
Jan 21, 2020

Conversation

allthesignals
Copy link
Collaborator

I swapped out the deprecated ember-cli-qunit for the new ember-qunit. This will address the timeout issues when using “this.pauseTest”.

I swapped out the deprecated ember-cli-qunit for the new ember-qunit. This will address the timeout issues when using “this.pauseTest”.
@allthesignals allthesignals requested a review from a team January 21, 2020 17:33
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #601 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #601   +/-   ##
========================================
  Coverage    54.94%   54.94%           
========================================
  Files          157      157           
  Lines         1518     1518           
========================================
  Hits           834      834           
  Misses         684      684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a437368...e3c1f78. Read the comment docs.

@godfreyyeung
Copy link
Contributor

So the timeout issues we faced were specifically address by one of the minor version releases?
Can you point to which change specifically? https://github.com/emberjs/ember-qunit/blob/master/CHANGELOG.md

And is this referring to the "tests timed out after 6000 ms" messages?

@allthesignals
Copy link
Collaborator Author

@godfreyyeung I think this was this issue: emberjs/ember-qunit#497. Yep, it's the "tests timed out after 6000".

@godfreyyeung
Copy link
Contributor

@godfreyyeung I think this was this issue: emberjs/ember-qunit#497. Yep, it's the "tests timed out after 6000".

Thanks! The info on the PR helped. Originally I didn't think timing out after 6000 ms was faulty behavior.

@allthesignals allthesignals merged commit 306c8ed into develop Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants