IOS-240 Integrate R2 changes for having publisher's defaults disabled #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestFan
approved these changes
Jul 16, 2021
ettore
force-pushed
the
story/IOS-240/disable-publisher-defaults
branch
from
e6530f6 to
32eb549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
Integrates the changes on the R2 repos so that we can configure the Publisher's defaults toggle as disabled by default.
Why are we doing this? (w/ JIRA link if applicable)
https://jira.nypl.org/browse/IOS-240
How should this be tested? / Do these changes have associated tests?
see ticket
Dependencies for merging? Releasing to production?
This requires a couple PRs on the R2 repos to be merged first:
readium/r2-shared-swift#157
readium/r2-navigator-swift#191
When those are merged, I will update our Cartfile.resolved accordingly before merging this PR.
Does this include changes that require a new SimplyE/Open eBooks build for QA?
yes
Has the application documentation been updated for these changes?
yes
Did someone actually run this code to verify it works?
@ettore