-
Notifications
You must be signed in to change notification settings - Fork 140
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Issue #90: proposal for dealing with repeats
if allow_repeats = False after a period where it is True then use the highest status associated with that worker as the exclusion criteria.
- Loading branch information
Showing
1 changed file
with
20 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d77ccf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem with this approach is, if they complete just once, they can bomb the next 1,000 and they'll never be stopped because max(status) will be that completed one.
EDIT: sorry, disregard this comment. This is confusing to me, too. I'm still mulling.
3d77ccf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have the whole vision now. Your code here is a nice approach.