Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement movsq #40

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Implement movsq #40

merged 7 commits into from
Oct 18, 2024

Conversation

oureveryday
Copy link
Contributor

Implement movsq I encountered in sprotect

NaC-L
NaC-L reviewed Oct 15, 2024
View reviewed changes
Copy link
Owner

@NaC-L NaC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent reviewed it properly, but we should be able to have one movsX function to do all movs, movsb, movsw... etc. we also should be able to get the size info from operands. That would be a more elegant solution

@oureveryday
Copy link
Contributor Author

I think maybe we have to pass a size paramater into that movsX?

@NaC-L
Copy link
Owner

NaC-L commented Oct 16, 2024

I am not exactly sure, but operands[1].size should give us the correct size, so we dont really need to pass a parameter.

@oureveryday
Copy link
Contributor Author

Done

NaC-L
NaC-L reviewed Oct 16, 2024
View reviewed changes
lifter/Semantics.cpp Outdated Show resolved Hide resolved
lifter/Semantics.cpp Outdated Show resolved Hide resolved
NaC-L
NaC-L approved these changes Oct 18, 2024
View reviewed changes
Copy link
Owner

@NaC-L NaC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NaC-L
Copy link
Owner

NaC-L commented Oct 18, 2024

thank you for your contribution

@NaC-L NaC-L merged commit 3e8c18d into NaC-L:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaC-L NaC-L NaC-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oureveryday @NaC-L