Linked files pattern logic and UI #1 #2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lays the groundwork for a tabular UI to configure filename patterns for linked files. The core logic is implemented, mirroring the structure used for Citation Key Patterns. UI implementation and integration with LinkedFilesTab will be addressed in later commits.
…on UI This commit replace the old ui with tabular UI to configure filename patterns for linked files. The core logic is implemented, mirroring the structure used for Citation Key Patterns. UI implementation and integration with LinkedFilesTab will be addressed in later commits.
This commit improves the UI and makes it functional. However, core logic still needs to be implemented.
IMPORTANT TODO:
1. Update CleanupPresetPanel.java in gui/cleanup:
- Temporarily added .toString() to filePreferences.getFileNamePattern()
- Need to modify this as the new GlobalFilenamePattern object stores patterns
for different file types, not just a single pattern
2. Refactor getSuggestedFileName in logic/externalfiles/LinkedFileHandler.java:
- Current implementation expects a single file name pattern
- Need to update to work with the new GlobalFilenamePattern object
Note: These changes may affect other parts of the application that rely on
the previous file name pattern implementation. Further testing and updates
may be required.
…files-pattern-logic-#2
This commit improves the UI and makes it functional. However, core logic still needs to be implemented.
IMPORTANT TODO:
1. Update CleanupPresetPanel.java in gui/cleanup:
- Temporarily added .toString() to filePreferences.getFileNamePattern()
- Need to modify this as the new GlobalFilenamePattern object stores patterns
for different file types, not just a single pattern
2. Refactor getSuggestedFileName in logic/externalfiles/LinkedFileHandler.java:
- Current implementation expects a single file name pattern
- Need to update to work with the new GlobalFilenamePattern object
Note: These changes may affect other parts of the application that rely on
the previous file name pattern implementation. Further testing and updates
may be required.
Major change: - Refactored `createFileNameFromPattern` in `FileUtil` to generate filenames dynamically based on the `EntryType`. - Add store and load for FilePreferences **Note:** Related test cases currently encounter compile errors and require fixes.
…files-pattern-logic-#2
There was a problem hiding this comment.
Do you want to delete the DatabaseFilenamePattern since it is not used and the FilenameGenerator since it is empty? Also one little things like pass the checkstyle test.
Otherwise, it looks good to me. Let me know if you want to change it, or I'm happy to approve and merge.
Thanks, I've made the changes. I initially planned to submit a draft PR to confirm if we're heading in the right direction, so the checkstyle issue isn't a big concern for now anyway. |
BruceLiang1234
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two related issues:
Major Changes Made:
UI Enhancements:
FilenamePatternPanelto manage patterns in a tabular format.{year}_{title}_{author}).Backend Logic:
FileUtilto generate filenames dynamically based on the patterns defined in the UI.GlobalFilenamePatternandAbstractFilenameFormatPatterns, etc. classes to support flexible pattern definitions and retrieval.FilePreferencesto store and manage filename patterns persistently.Some change in test:
Issue Links:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)