Add raise_for_status in cloudhook #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
approved these changes
Jun 12, 2020
pvizeli
reviewed
Jun 12, 2020
| @@ -41,6 +41,7 @@ async def async_create(self, webhook_id: str, managed: bool) -> Dict[str, Any]: | |||
| with async_timeout.timeout(10): | |||
| resp = await cloud_api.async_create_cloudhook(self.cloud) | |||
|
|
|||
| resp.raise_for_status() | |||
There was a problem hiding this comment.
I think we should raise a own Exception, catch that on HA and make a better error handling with a nice message. Now we replace the exception from json with the exception from aiohttp.
There was a problem hiding this comment.
Let's do that in another PR. For now we should at least raise. Currently you get a key error because it treats it as valid data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only HTTP call we had that didn't check status.