Don't keep fetching snitun token when sub expired #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -283,6 +291,8 @@ async def connect(self) -> None: | |||
| _LOGGER.error("Connection problem to snitun server") | |||
| except RemoteBackendError: | |||
| _LOGGER.error("Can't refresh the snitun token") | |||
| except SubscriptionExpired: | |||
| pass | |||
There was a problem hiding this comment.
Do we communicate this state some other way to interested parties?
There was a problem hiding this comment.
No. We just have this property which is updated once an hour when we update auth tokens. Future PR we can add some logic for responding to that.
MartinHjelmare
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sub expired, don't try to keep fetching snitun tokens.
This is a quick fix. In the future we should redo this code to have "sub activated" and "sub deactivated" hooks.