Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloud ICE server fetch update and reset logic #756

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

klejejs
Copy link
Contributor

@klejejs klejejs commented Dec 3, 2024

There were some issues with the current logic, so it is updated in the following ways:

  • If the cloud subscription has expired, there is no point in fetching new servers, and they should be set to an empty list.
  • If, for some reason, the fetching does happen and 401 or 403 is returned, we should reset the ICE servers to an empty list instead of leaving them there and having the code reattempt fetching them based on the existing timestamps.
  • The listener should be called even on request error as the servers might now change also in those cases.
  • The listener should be called even on an empty ICE servers list as we don't need old servers with credentials to be left for HA to use.

@klejejs klejejs force-pushed the fix/ice-server-fetching-and-reset-logic branch from ab3e1c9 to b33cc6d Compare December 3, 2024 17:38
@klejejs klejejs requested review from bemble and ludeeus December 4, 2024 23:40
@klejejs klejejs merged commit 2f89d0c into master Dec 5, 2024
3 checks passed
@klejejs klejejs deleted the fix/ice-server-fetching-and-reset-logic branch December 5, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants