Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MFA login flow #757

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Add support for MFA login flow #757

merged 9 commits into from
Dec 12, 2024
+118 −2

Conversation

klejejs
Copy link
Contributor

@klejejs klejejs commented Dec 6, 2024 •
edited
Loading

SSIA.

@klejejs klejejs mentioned this pull request Dec 6, 2024
Open
19 tasks
oliverlorenz
oliverlorenz previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@oliverlorenz oliverlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good in general 🚀 ✨ 🥳 I like it 👍

Can you explain me, how the decision is made, when MFA is activated? It seems it can be configured in Congnito, right? And on which Level? Du we decide that, can the user decide this?

ludeeus
ludeeus reviewed Dec 9, 2024
View reviewed changes
hass_nabucasa/auth.py Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Dec 11, 2024
View reviewed changes
hass_nabucasa/auth.py Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Dec 11, 2024
View reviewed changes
hass_nabucasa/auth.py Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Dec 11, 2024
View reviewed changes
hass_nabucasa/auth.py Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Dec 11, 2024
View reviewed changes
hass_nabucasa/const.py Outdated Show resolved Hide resolved
@klejejs klejejs force-pushed the feat/add-mfa-support branch from 862d7c0 to 5ddb83d Compare December 11, 2024 14:25
@klejejs klejejs merged commit 70fc4e6 into master Dec 12, 2024
3 checks passed
@klejejs klejejs deleted the feat/add-mfa-support branch December 12, 2024 10:50
@klejejs klejejs mentioned this pull request Dec 12, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeeus ludeeus ludeeus approved these changes

@oliverlorenz oliverlorenz oliverlorenz left review comments

@bemble bemble Awaiting requested review from bemble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klejejs @oliverlorenz @ludeeus