Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server.wait_closed in test fixtures #217

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ludeeus
Copy link
Contributor

@ludeeus ludeeus commented Nov 24, 2023

This was never intended to stop/close the server, and with 3.12 this just hangs forever.
ref: python/cpython#104344

@ludeeus ludeeus mentioned this pull request Nov 24, 2023
@ludeeus ludeeus merged commit 5445807 into main Nov 24, 2023
4 checks passed
@ludeeus ludeeus deleted the remove-server.wait_closed-in-fixtures branch November 24, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants