Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk renderer update #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vk renderer update #10

wants to merge 1 commit into from

Conversation

wsqjny
Copy link

@wsqjny wsqjny commented Feb 19, 2021

Hi~ I'm new to vulkan. very happy to see your pbr demo source, it helps me a lot.
However, I found in the new version of vulkan (1.2.154.1), the following two places seem to need to be changed:

  1. Validation Layers changed : VK_LAYER_LUNARG_standard_validation -> VK_LAYER_KHRONOS_validation.
    https://vulkan.lunarg.com/doc/view/1.1.114.0/windows/validation_layers.html

  2. There are some image layout warnings when running, like ".....(subresource: aspectMask 0x1 array layer 0, mip level 1) to be in layout VK_IMAGE_LAYOUT_GENERAL--instead, current layout is VK_IMAGE_LAYOUT_UNDEFINED."
    It seems that all the mips of the "envTextureUnfiltered" image shouled be changed before cs dispatch.

Thank you~

…> VK_LAYER_KHRONOS_validation

2. fix bug: update all mips of "envTextureUnfiltered" image layout before cs dispatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant