Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use different script when executing on Windows-based machines #12

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

Namchee
Copy link
Owner

@Namchee Namchee commented Aug 1, 2021

Overview

Closes #11

This pull request fixes the script when running on Windows by executing a different script npm.cmd when checking the package installation. See here for more information about why the script must use npm.cmd.

Caveats

Need to test on even more OS, will this break on any other OSes?

@Namchee Namchee merged commit 945ef4d into master Aug 1, 2021
@Namchee Namchee deleted the fix/windows branch August 1, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Failed to run on Windows
1 participant