FANBOX posts without cover image now completely break downloader (only on master)

[somebody1234]

Prerequisites

• Did you read FAQ section in readme.md?
• Did you test with the latest releases or commit ?
• Did you search for existing issues in Issues?

Description

See title.

this is the line creating the issue.

PixivUtil2/PixivModelFanbox.py

Line 167 in 7feb27d

if not self.coverImageUrl and coverUrl:

i'd advise changing the default to None here:

PixivUtil2/PixivModelFanbox.py

Line 96 in 7feb27d

coverImageUrl = ""

Steps to Reproduce

1. Try to download FANBOX artist with a post without cover iamge

Expected behavior: No error

Actual behavior: Error

Versions

Master (7feb27d) and newer

[Nandaka]

most likely due to changes in #951 @bluerthanever

@somebody1234 do you have the sample post id and the error message?

[bluerthanever]

sorry i wanted to test with posts without cover but i didn't find any... i will have a look at it

[somebody1234]

this one maybe? as sample post

[somebody1234]

error message:

Traceback (most recent call last):
  File "/mnt/ntfs/MEGA/pixivutil20200827-beta1/PixivUtil2/PixivDownloadHandler.py", line 78, in download_image
    remote_file_size = get_remote_filesize(url, referer, config, notifier)
  File "/mnt/ntfs/MEGA/pixivutil20200827-beta1/PixivUtil2/PixivDownloadHandler.py", line 294, in get_remote_filesize
    res = br.open_novisit(req)
  File "/home/me/.local/lib/python3.9/site-packages/mechanize/_mechanize.py", line 241, in open_novisit
    return self._mech_open(
  File "/home/me/.local/lib/python3.9/site-packages/mechanize/_mechanize.py", line 287, in _mech_open
    response = UserAgentBase.open(self, request, data)
  File "/home/me/.local/lib/python3.9/site-packages/mechanize/_opener.py", line 173, in open
    req_scheme = req.get_type()
  File "/home/me/.local/lib/python3.9/site-packages/mechanize/_urllib2_fork.py", line 260, in get_type
    raise ValueError("unknown url type: %s" % self.__original)
ValueError: unknown url type:
Error at download_image(): (<class 'ValueError'>, ValueError('unknown url type: '), <traceback object at 0x7f79154d2a40>) at  (9000)

[somebody1234]

most likely due to changes in #951

@Nandaka yes, the blame says so as well

[Nandaka]

changes merged