partial implementation of #949 and #930 enhancement adjustments #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. removed some codes from implementation full sized cover image enhancement
2. added `descriptionUrlList` for `FanboxPost` to use `PixivHelper.write_url_in_description` to write urls
i just added urls that could be found in html body which are not images, p blocks, and embeds.
calls `PixivHelper.write_url_in_description` after processing all images, writing information and htmls
|
i changed some codes from 930 implementation because i think some are not so necessary, for example the new field for |
Nandaka
reviewed
May 17, 2021
Nandaka
reviewed
May 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PixivHelper.write_url_in_descriptionto write urls to file.