Fixes my bad on past attempt to deal with BOM #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously write bom segment wrote garbage instead of actual byte order mark on every system. With this I remove a NIH fix and add a system-dependent definition for download file encoding, so on Windows there would no need to fix BOM and on Linux there's no need to remove BOM for scripting with Downloaded file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the "write bom segment" code wrote garbage instead of actual byte order mark.
With this I remove a not-invented-here fix for this whole irfan view problem and add a system-dependent definition for downloaded list file encoding, so on Windows there would no need to fix BOM when I want to see all my fresh pictures and on Linux there's no need to remove BOM for scripting with Downloaded file.