Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Add missing fields column for integrations to db #3045

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Nov 22, 2024

We need a stored set of issues on integrations so that we can show those issues in the UI. This will add the new column and ensure that it's migrated properly and handled appropriately in the app.

  • Add new column
  • Set up validation function for integrations
  • Update creating integrations to fill in fields
  • Update updating integrations to fill in fields

A future PR will migrate existing providers to note their missing fields correctly since, and then we'll be able to utilize those in the dashboard.

https://linear.app/nango/issue/NAN-2168/surface-integrationsconnections-errors-in-nango-ui

How I Tested It

  • Run the tests
  • Click through adding a new oauth based integration
  • Note that missing_fields is set for it in the DB
  • Update that integration
  • Note that missing_fields has been updated accordingly

Copy link

linear bot commented Nov 22, 2024

@nalanj nalanj self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant