fix(server): Remove secrets from in app integration api response #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Nov 22, 2024
bodinsamuel
reviewed
Nov 23, 2024
| delete apiIntegration.oauth_client_secret_iv; | ||
| delete apiIntegration.oauth_client_secret_tag; | ||
|
|
||
| return apiIntegration; |
There was a problem hiding this comment.
The type IntegrationConfig is invalid, it states that those values are undefined but they are not, they can be nullable though. It can't be fixed yet because of legacy code (it's more or less always the issue each time). Right now, the best fix could look like this for the type:
export type ApiIntegration = Omit<Merge<IntegrationConfig, ApiTimestamps>, 'oauth_client_secret_iv' | 'oauth_client_secret_tag'>;And then instead of spreading which does not trigger a Typescript error because the interface is still compatible, it should be assigned field by field (like endUser, connection). I forgot about this annoying "issue" for this formatter and a few others (team, invitation, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized were were sending some fields that we'd prefer not to send in the internal api responses for integrations. This PR makes sure those aren't returned.
How I Tested It