Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Summary Stats feature #302

Merged
merged 26 commits into from
Jun 19, 2023
Merged

Adding Summary Stats feature #302

merged 26 commits into from
Jun 19, 2023

Conversation

nikml
Copy link
Contributor

@nikml nikml commented Jun 6, 2023

Commit 8cd46a23b should be reverted before merging as it updates python versions. Used it to help with dev setup.

@nikml nikml requested a review from nnansters as a code owner June 6, 2023 11:30
nikml and others added 3 commits June 6, 2023 15:31
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 89.64% and project coverage change: +0.52 🎉

Comparison is base (cb338cc) 83.22% compared to head (2a5e4fe) 83.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   83.22%   83.74%   +0.52%     
==========================================
  Files          82      100      +18     
  Lines        6431     7130     +699     
  Branches      974     1254     +280     
==========================================
+ Hits         5352     5971     +619     
- Misses        818      862      +44     
- Partials      261      297      +36     
Impacted Files Coverage Δ
nannyml/io/raw_files_writer.py 75.00% <ø> (ø)
nannyml/thresholds.py 85.71% <ø> (ø)
nannyml/data_quality/unseen/__init__.py 80.00% <50.00%> (-20.00%) ⬇️
nannyml/base.py 83.11% <66.66%> (+0.77%) ⬆️
nannyml/stats/base.py 80.00% <80.00%> (ø)
nannyml/stats/avg/calculator.py 86.51% <86.51%> (ø)
nannyml/stats/sum/calculator.py 86.51% <86.51%> (ø)
nannyml/stats/median/calculator.py 86.66% <86.66%> (ø)
nannyml/stats/std/calculator.py 86.66% <86.66%> (ø)
nannyml/stats/avg/result.py 92.00% <92.00%> (ø)
... and 16 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pyproject.toml Outdated Show resolved Hide resolved
@nnansters nnansters merged commit 990505c into main Jun 19, 2023
@nikml nikml deleted the feature/summary_stats branch June 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants