Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional prediction column: the return #381

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

nnansters
Copy link
Contributor

Metric classes were not able to deal with optional predictions yet.

Updated the base class and (unfortunately) added asserts to keep mypy from complaining. Didn't want that logic to leak into remove_nans

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.52%. Comparing base (e98cab9) to head (bdeac0a).
Report is 1 commits behind head on main.

Files Patch % Lines
nannyml/performance_calculation/calculator.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   78.41%   78.52%   +0.10%     
==========================================
  Files         110      110              
  Lines        8520     8562      +42     
  Branches     1514     1522       +8     
==========================================
+ Hits         6681     6723      +42     
  Misses       1476     1476              
  Partials      363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review April 29, 2024 23:16
@nnansters nnansters requested a review from nikml as a code owner April 29, 2024 23:16
@nnansters nnansters merged commit fa78f5a into main Apr 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant