-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Numerical Range Data Quality Check #408
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 76.80% 77.43% +0.63%
==========================================
Files 108 111 +3
Lines 9264 9444 +180
Branches 1656 1684 +28
==========================================
+ Hits 7115 7313 +198
+ Misses 1685 1668 -17
+ Partials 464 463 -1 ☔ View full report in Codecov by Sentry. |
What's this!? A shiny new calculator?! I'll take a closer look at your PR at the end of this week, but already a big fat "thank you" @jnesfield ! |
NP! I was chatting about this with Hakim E. and decided to give it a whirl! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, but I'll take care of them quickly. Just wanted to explain the little changes I'll make.
Because it fits the use case better!
To ensure the result object also contains results for the reference period. Even if they're all just 0 by definition.
Adjusting some comments and general linting stuff
There we go, also added some texts. That's good to go for me! There is quite a bit of boilerplate going on right now, I'm hoping to do something about that soon. Feel free to incorporate any other ideas you might have! Once again, thank you for your contribution, much appreciated! |
Added a data quality check for numerical range on continuous columns. I also updated the examples for the existing data quality classes as they had errors when I attempted them. I still need to add testing within ~tree/main/tests/data_quality and will work on those later. Attached is a notebook containing some examples and testing I did.
Untitled19.zip