Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on non negligible cost of finite differences to tutorial on shape derivatives #2883

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Aug 11, 2024

Adds the following note to Tutorial/Derivatives with Respect to Shape Parameters:

A finite difference involves two function evaluations of $\rho(h)$, but the cost for this is negligible since it involves no Meep simulations. However, in cases when there are a large number of shape parameters and a dense design grid, the cost of the finite differences can be non negligible: $M$ shape parameters require $M$ finite differences each involving $N$ grid points.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.78%. Comparing base (f29a8c7) to head (afb83b0).
Report is 29 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
- Coverage   73.81%   73.78%   -0.04%     
==========================================
  Files          18       18              
  Lines        5423     5428       +5     
==========================================
+ Hits         4003     4005       +2     
- Misses       1420     1423       +3     

@oskooi oskooi merged commit bea1b20 into NanoComp:master Aug 12, 2024
5 checks passed
@oskooi oskooi deleted the material_derivative_cost branch August 12, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants