Adding more features to TDR window #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug with setuptools_scm not being able to find .git
Fix math with TDR
Allow for plotting of S11 and VSWR
Allow user to select |Z|, VSWR, or S11
typo
zarath
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
The user is only allowed to plot the magnitude of the impedance (or |Z|)
What is the new behavior?
The user is now allowed to select from a menu whether they want to plot |Z|, S11, or VSWR. This would allow the user to display their data in a different format
Does this introduce a breaking change?
Other information
Here is what everything looks like now:
Maybe in the future you can plot real/imaginary?