Allow Touchstone files for calibration #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarath
approved these changes
Nov 28, 2024
zarath
pushed a commit
to zarath/nanovna-saver
that referenced
this pull request
Nov 30, 2024
* Update Calibration.py * Update Touchstone.py * Update CalibrationSettings.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the type of change your PR introduces:
What is the current behavior?
Right now, you can either use ideal values or use coefficients (if your cal components are not ideal). However, if you use a VNA to measure your calibration kit, you just get a S1P file. While it is possible to derive the coefficients for the short and open, the load seems to be more complicated, especially at higher frequencies.
What is the new behavior?
You are now able to input S1P files for calibration.
Does this introduce a breaking change?
Other information
I imported this S11 file for the open:
My results after calibration:
You can see that at 8GHz the phase is roughly 10 degrees.
For the load, I imported the blue trace here (S22):
Here are the results after calibration:
(The VNA loses directivity above 6.3GHz which is why the return loss has spikes).
Here is what the change looks like:
