Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: improve grammar, structure and add crux install instructions. #4

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Conversation

lwilletts
Copy link
Contributor

Hopefully this will help, I've tried to keep as much as the original readme as possible while cleaning up grammar and the like seeing as (correct me if I'm wrong) you're not a native english speaker.

@Nanoseb
Copy link
Owner

Nanoseb commented Apr 13, 2016

Thanks a lot!

@Nanoseb Nanoseb merged commit 2e06c5f into Nanoseb:master Apr 13, 2016
@Nanoseb
Copy link
Owner

Nanoseb commented Apr 13, 2016

Just a question, why did you change '#' into '$'?
Isn't # the usual symbol for a root command and $ for a non root one?

@lwilletts
Copy link
Contributor Author

I don't think I've ever seen that distinction before... It might just be simpler to preface commands that need root with sudo, as that'd be more understood on a glance.

@Nanoseb
Copy link
Owner

Nanoseb commented Apr 13, 2016

I have added 'sudo' when needed, but because I don't know crux I haven't edited this section, anyway I am not sure people using this distro need this kind of indication.

@lwilletts
Copy link
Contributor Author

No they certainly do not :D

@Nanoseb
Copy link
Owner

Nanoseb commented Apr 19, 2016

python-psutil is now needed, you may need to update your crux repo

@lwilletts
Copy link
Contributor Author

What new weird and wonderful features have you added? ;)

@Nanoseb
Copy link
Owner

Nanoseb commented Apr 19, 2016

Something to check if telegram-cli is running and the port available see #7, I thought this lib was by default with python core but it seems it is not. I really don't like adding dependencies when it is not needed, so when I will have more time I will probably look for something else, but still it is the most clever way to check that.

EDIT: I didn't notice that you were the one who reported the issue #7 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants