Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -g option work for 3ware interface #30

Closed
karaluh opened this issue Jan 8, 2019 · 3 comments
Closed

Make -g option work for 3ware interface #30

karaluh opened this issue Jan 8, 2019 · 3 comments
Labels
enhancement help wanted needs testing

Comments

@karaluh
Copy link

karaluh commented Jan 8, 2019

This is already supported for megaraid interface.
@Napsty
Copy link
Owner

Napsty commented Nov 22, 2019

Hi @karaluh
Can you try it with this version and let me know if this works?
https://github.com/Napsty/check_smart/blob/issue-30/check_smart.pl

I don't have any 3ware raid controllers at hand so I can't test it properly.

@Napsty
Copy link
Owner

Napsty commented Nov 22, 2019 •
edited
Loading

Hi @karaluh
I was able to add cciss, too. As I have HP servers to test with, this seems to work correctly.
At the same time I also adjusted the output of the plugin when -g is used in combination with megaraid, cciss or 3ware glob.

Before:

# ./check_smart.pl -g /dev/sda -i 'cciss,[1-3]'
OK: [/dev/sda] - Device is clean --- [/dev/sda] - Device is clean --- [/dev/sda] - Device is clean|

New:

# ./check_smart.pl -g /dev/sda -i 'cciss,[1-3]'
OK: [cciss,1] - Device is clean --- [cciss,2] - Device is clean --- [cciss,3] - Device is clean|

@Napsty Napsty mentioned this issue Nov 29, 2019
Merged
Napsty added a commit that referenced this issue Nov 29, 2019
@Napsty
Make -g option available for 3ware and cciss controllers (#49)
6199f89 
The feature was requested in #30 . This PR adds the possibility to use 3ware,N and cciss,N drives in combination with the global -g parameter.

Furthermore this PR adjusts the output of the plugin when the -g is used in combination with hardware raid controllers. Instead of showing the logical device name (/dev/sda for example), the plugin will now show the controller with drive number.
@Napsty
Copy link
Owner

Napsty commented Nov 29, 2019

Solved in Version 6.6.

@Napsty Napsty closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted needs testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Napsty @karaluh