create-react-app 2.1.2 has a breaking change for webpack config file location #18
Conversation
There was a problem hiding this comment.
Thanks for your contribution @kaltepeter. To test with an ejected project this is really easy, just eject a bare new CRA project so you can see how the files are laid out (that's how I did previously). Let me know if you need help with that.
| @@ -14,8 +14,8 @@ const { getReactScriptsVersion, isEjected } = require('../utils'); | |||
| const paths = isEjected ? importCwd('./config/paths') : importCwd('react-scripts/config/paths'); | |||
| const webpack = importCwd('webpack'); | |||
| const config = isEjected | |||
| ? importCwd('./config/webpack.config.dev') | |||
| : importCwd('react-scripts/config/webpack.config.dev'); | |||
| ? importCwd('./config/webpack.config')('development') | |||
There was a problem hiding this comment.
I'm afraid it will be a bit more complicated than that. If we do that, we break the backward compatibility with react-scripts previous version. You need to use the react-scripts version that are available to you higher up:
cra-build-watch/scripts/index.js
Line 13 in cd8ddd7
webpack.config file path or your new version. To see an example of how it is used: cra-build-watch/scripts/index.js
Line 55 in cd8ddd7
We also need to check that the array indexes have not changed and remain the same in the second line of code I linked.
| @@ -11,7 +11,7 @@ const DEFAULT_VERSION = { | |||
| patch: 4, | |||
| }; | |||
|
|
|||
| exports.isEjected = fs.pathExistsSync(path.join(process.cwd(), 'config/webpack.config.dev.js')); | |||
| exports.isEjected = fs.pathExistsSync(path.join(process.cwd(), 'config/webpack.config.js')); | |||
|
Closed in favor of already merged: #20 |
create-react-app 2.1.2 makes a breaking changes merging the webpack paths into a single config. see: facebook/create-react-app#5722
This fixes the breaking change to load the single webpack.config.js with 'development' as the environment to load.
I don't have react apps with ejected config so that path is untested.
I have tested non-ejected create-react-app and it runs again.
to test locally:
npm i -D github:kaltepeter/cra-build-watch#update-webpack-paths