forked from marketplacer/barcodevalidation
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Addressed Rubocop concerns from PR 29
Rubocop checks in PR marketplacer#29 did not fire, so issues were not discovered until release. This corrects them, making Rubocop and tests pass. - GTIN module was 31 lines (max 30), so I inlined a guard clause - Use of redundant `self.` was removed - Prefer `__send__` over `send` when `public_send` is not an option
- Loading branch information
Showing
3 changed files
with
3 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters